From 45699c7e51b0ddb1249ce7ab295cde42ade0b5d8 Mon Sep 17 00:00:00 2001
From: Roland Gruber <post@rolandgruber.de>
Date: Tue, 29 Jun 2010 17:18:50 +0000
Subject: [PATCH] reduce PHP notices

---
 lam/lib/modules/sambaSamAccount.inc | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lam/lib/modules/sambaSamAccount.inc b/lam/lib/modules/sambaSamAccount.inc
index 58c0ff1b..4713451c 100644
--- a/lam/lib/modules/sambaSamAccount.inc
+++ b/lam/lib/modules/sambaSamAccount.inc
@@ -798,7 +798,7 @@ class sambaSamAccount extends baseModule implements passwordService {
 		// host attributes
 		if ($this->get_scope()=='host') {
 			$this->attributes['sambaPrimaryGroupSID'][0] = $SID."-".$this->rids[_('Domain computers')];
-			if ($_POST['ResetSambaPassword'] || !$this->attributes['sambaNTPassword'][0]) {
+			if (isset($_POST['ResetSambaPassword']) || !isset($this->attributes['sambaNTPassword'][0])) {
 				$hostname = $attrs['uid'][0];
 				$hostname = substr($hostname, 0, strlen($hostname) - 1);
 				if (isset($this->moduleSettings['sambaSamAccount_lmHash'][0]) && ($this->moduleSettings['sambaSamAccount_lmHash'][0] == 'no')) {
@@ -883,7 +883,7 @@ class sambaSamAccount extends baseModule implements passwordService {
 			}
 		}
 		else {  // host
-			if (!$this->attributes['sambaSID'][0]) {
+			if (!isset($this->attributes['sambaSID'][0])) {
 				$this->attributes['sambaSID'][0] = $SID."-". (($attrs['uidNumber'][0]*2)+$RIDbase);
 			}
 		}
@@ -1673,38 +1673,38 @@ class sambaSamAccount extends baseModule implements passwordService {
 		// profile mappings in meta data
 		parent::load_profile($profile);
 		// add extension
-		if ($profile['sambaSamAccount_addExt'][0] == "true") {
+		if (isset($profile['sambaSamAccount_addExt'][0]) && ($profile['sambaSamAccount_addExt'][0] == "true")) {
 			if (!in_array('sambaSamAccount', $this->attributes['objectClass'])) {
 				$this->attributes['objectClass'][] = 'sambaSamAccount';
 			}
 		}
 		// use no password
-		if ($profile['sambaSamAccount_sambaAcctFlagsN'][0] == "true") {
+		if (isset($profile['sambaSamAccount_sambaAcctFlagsN'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsN'][0] == "true")) {
 			$this->nopwd = true;
 		}
-		elseif ($profile['sambaSamAccount_sambaAcctFlagsN'][0] == "false") {
+		elseif (isset($profile['sambaSamAccount_sambaAcctFlagsN'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsN'][0] == "false")) {
 			$this->nopwd = false;
 		}
 		// password expiration
-		if ($profile['sambaSamAccount_sambaAcctFlagsX'][0] == "true") {
+		if (isset($profile['sambaSamAccount_sambaAcctFlagsX'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsX'][0] == "true")) {
 			$this->noexpire = true;
 		}
-		elseif ($profile['sambaSamAccount_sambaAcctFlagsX'][0] == "false") {
+		elseif (isset($profile['sambaSamAccount_sambaAcctFlagsX'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsX'][0] == "false")) {
 			$this->noexpire = false;
 		}
 		// use no password
-		if ($profile['sambaSamAccount_sambaAcctFlagsD'][0] == "true") {
+		if (isset($profile['sambaSamAccount_sambaAcctFlagsD'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsD'][0] == "true")) {
 			$this->deactivated = true;
 		}
-		elseif ($profile['sambaSamAccount_sambaAcctFlagsD'][0] == "false") {
+		elseif (isset($profile['sambaSamAccount_sambaAcctFlagsD'][0]) && ($profile['sambaSamAccount_sambaAcctFlagsD'][0] == "false")) {
 			$this->deactivated = false;
 		}
 		if (!$this->isBooleanConfigOptionSet('sambaSamAccount_hideHomeDrive')) {
 			// home drive
-			if ($profile['sambaSamAccount_sambaHomeDrive'][0] == "-") {
+			if (isset($profile['sambaSamAccount_sambaHomeDrive'][0]) && ($profile['sambaSamAccount_sambaHomeDrive'][0] == "-")) {
 				$this->attributes['sambaHomeDrive'][0] = '';
 			}
-			elseif ($profile['sambaSamAccount_sambaHomeDrive'][0]) {
+			elseif (isset($profile['sambaSamAccount_sambaHomeDrive'][0])) {
 				$this->attributes['sambaHomeDrive'][0] = $profile['sambaSamAccount_sambaHomeDrive'][0];
 			}
 		}