From 8592d8da74e1918820affd32d21aaf64d8cfd4f3 Mon Sep 17 00:00:00 2001
From: Roland Gruber <post@rolandgruber.de>
Date: Sat, 20 Apr 2013 15:14:03 +0000
Subject: [PATCH] performance fixes

---
 lam/lib/modules/posixGroup.inc | 3 ++-
 lam/lib/types/user.inc         | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lam/lib/modules/posixGroup.inc b/lam/lib/modules/posixGroup.inc
index 5b700501..a3503385 100644
--- a/lam/lib/modules/posixGroup.inc
+++ b/lam/lib/modules/posixGroup.inc
@@ -962,7 +962,8 @@ class posixGroup extends baseModule implements passwordService {
 		}
 		$result = searchLDAPByAttribute('gidNumber', '*', 'posixAccount', array('uid', 'gidNumber', 'cn'), array('user'));
 		$this->cachedUserToGIDList = array();
-		for ($i = 0; $i < sizeof($result); $i++) {
+		$resultCount = sizeof($result);
+		for ($i = 0; $i < $resultCount; $i++) {
 			$this->cachedUserToGIDList[$result[$i]['uid'][0]] = array('gid' => $result[$i]['gidnumber'][0], 'cn' => $result[$i]['cn'][0]);
 		}
 		return $this->cachedUserToGIDList;
diff --git a/lam/lib/types/user.inc b/lam/lib/types/user.inc
index f011eb44..a1f52a22 100644
--- a/lam/lib/types/user.inc
+++ b/lam/lib/types/user.inc
@@ -566,7 +566,8 @@ class lamUserList extends lamList {
 		$filter = "objectClass=posixGroup";
 		$attrs = array("cn", "gidNumber");
 		$entries = searchLDAPByAttribute(null, null, 'posixGroup', $attrs, array('group'));
-		for ($i = 0; $i < sizeof($entries); $i++) {
+		$entryCount = sizeof($entries);
+		for ($i = 0; $i < $entryCount; $i++) {
 			$this->trans_primary_hash[$entries[$i]['gidnumber'][0]] = $entries[$i]['cn'][0];
 		}
 	}
@@ -758,7 +759,8 @@ class lamUserList extends lamList {
 	 * Injects values for the virtual account status attribute to make it sortable.
 	 */
 	private function injectAccountStatusAttribute() {
-		for ($i = 0; $i < sizeof($this->entries); $i++) {
+		$entryCount = sizeof($this->entries);
+		for ($i = 0; $i < $entryCount; $i++) {
 			$status = 0;
 			if (!self::isUnixLocked($this->entries[$i])) {
 				$status++;