refactoring

4 years ago · de19770211
parent 27a4234634
commit de19770211
3 changed files with 118 additions and 107 deletions
--- a/lam/lib/2factor.inc
+++ b/lam/lib/2factor.inc
@ -1,5 +1,6 @@
 <?php
 namespace LAM\LIB\TWO_FACTOR;
+use LAM\LOGIN\WEBAUTHN\WebauthnManager;
 use \selfServiceProfile;
 use \LAMConfig;
 use \htmlScript;
@ -551,7 +552,8 @@ class WebauthnProvider extends BaseProvider {
 		$row->add(new htmlDiv(null, $errorMessage, array('hidden webauthn-error')), 12);
 		if ($this->config->twoFactorAuthenticationOptional === true) {
 			include_once __DIR__ . '/webauthn.inc';
-			$hasTokens = hasTokensRegistered($userDn);
+			$webauthnManager = new WebauthnManager();
+			$hasTokens = $webauthnManager->isRegistered($userDn);
 			if (!$hasTokens) {
 				$skipButton = new htmlButton('skip_webauthn', _('Skip'));
 				$skipButton->setCSSClasses(array('fullwidth'));
@ -572,7 +574,8 @@ class WebauthnProvider extends BaseProvider {
 	public function verify2ndFactor($user, $password, $serial, $twoFactorInput) {
 		logNewMessage(LOG_DEBUG, 'WebauthnProvider: Checking 2nd factor for ' . $user);
 		include_once __DIR__ . '/webauthn.inc';
-		if ($this->config->twoFactorAuthenticationOptional && !hasTokensRegistered($user) && ($_POST['sig_response'] === 'skip')) {
+		$webauthnManager = new WebauthnManager();
+		if ($this->config->twoFactorAuthenticationOptional && !$webauthnManager->isRegistered($user) && ($_POST['sig_response'] === 'skip')) {
 			return true;
 		}
 		$response = base64_decode($_POST['sig_response']);
--- a/lam/lib/webauthn.inc
+++ b/lam/lib/webauthn.inc
@ -72,103 +72,124 @@ use \LAMException;
 include_once __DIR__ . '/3rdParty/composer/autoload.php';

 /**
- * Returns if the given DN is registered for webauthn.
+ * Manages Webauthn registrations and authentications.
 *
- * @param string $dn DN
- * @return boolean is registered
+ * @package LAM\LOGIN\WEBAUTHN
 */
-function isRegistered($dn) {
-	return false;
-}
+class WebauthnManager {

-/**
- * Returns a challenge for a new token.
- *
- * @param string $dn DN
- * @param bool $isSelfService is executed in self service
- * @return PublicKeyCredentialCreationOptions registration object
- */
-function getRegistrationObject($dn, $isSelfService) {
-	$rpEntity = createRpEntry($isSelfService);
-	$userEntity = getUserEntity($dn);
-	$challenge = generateRandomPassword(32);
-	$credentialParameters = getCredentialParameters();
-	$excludedKeys = getExcludedKeys($userEntity);
-	$timeout = 20000;
-	$registrationObject = new PublicKeyCredentialCreationOptions(
-		$rpEntity,
-		$userEntity,
-		$challenge,
-		$credentialParameters,
-		$timeout,
-		$excludedKeys,
-		new AuthenticatorSelectionCriteria(),
-		PublicKeyCredentialCreationOptions::ATTESTATION_CONVEYANCE_PREFERENCE_NONE,
-		new AuthenticationExtensionsClientInputs());
-	logNewMessage(LOG_DEBUG, 'Webauthn registration: ' . json_encode($registrationObject));
-	return $registrationObject;
-}
+	/**
+	 * Returns if the given DN is registered for webauthn.
+	 *
+	 * @param string $dn DN
+	 * @return boolean is registered
+	 */
+	public function isRegistered($dn) {
+		$database = $this->getDatabase();
+		$userEntity = $this->getUserEntity($dn);
+		$results = $database->findAllForUserEntity($userEntity);
+		return !empty($results);
+	}

-/**
- * Returns the part that identifies the server and application.
- *
- * @param bool $isSelfService is executed in self service
- * @return PublicKeyCredentialRpEntity relying party entry
- */
-function createRpEntry($isSelfService) {
-	$pathPrefix = $isSelfService ? '../' : '';
-	$icon = $pathPrefix . '../graphics/logo136.png';
-	if (!$isSelfService) {
-		$domain = $_SESSION['config']->getTwoFactorAuthenticationDomain();
+	/**
+	 * Returns a challenge for a new token.
+	 *
+	 * @param string $dn DN
+	 * @param bool $isSelfService is executed in self service
+	 * @return PublicKeyCredentialCreationOptions registration object
+	 */
+	public function getRegistrationObject($dn, $isSelfService) {
+		$rpEntity = $this->createRpEntry($isSelfService);
+		$userEntity = $this->getUserEntity($dn);
+		$challenge = generateRandomPassword(32);
+		$credentialParameters = $this->getCredentialParameters();
+		$excludedKeys = $this->getExcludedKeys($userEntity);
+		$timeout = 20000;
+		$registrationObject = new PublicKeyCredentialCreationOptions(
+			$rpEntity,
+			$userEntity,
+			$challenge,
+			$credentialParameters,
+			$timeout,
+			$excludedKeys,
+			new AuthenticatorSelectionCriteria(),
+			PublicKeyCredentialCreationOptions::ATTESTATION_CONVEYANCE_PREFERENCE_NONE,
+			new AuthenticationExtensionsClientInputs());
+		logNewMessage(LOG_DEBUG, 'Webauthn registration: ' . json_encode($registrationObject));
+		return $registrationObject;
 	}
-	return new PublicKeyCredentialRpEntity(
-		'LDAP Account Manager', //Name
-		$domain,
-		$icon
-	);
-}

-/**
- * Returns the user entity for the registration.
- *
- * @param $dn DN
- * @return PublicKeyCredentialUserEntity user entity
- */
-function getUserEntity($dn) {
-	return new PublicKeyCredentialUserEntity(
-		$dn,
-		$dn,
-		extractRDNValue($dn),
-		null
-	);
-}
+	/**
+	 * Returns the user entity for the registration.
+	 *
+	 * @param $dn DN
+	 * @return PublicKeyCredentialUserEntity user entity
+	 */
+	private function getUserEntity($dn) {
+		return new PublicKeyCredentialUserEntity(
+			$dn,
+			$dn,
+			extractRDNValue($dn),
+			null
+		);
+	}

-/**
- * Returns the supported credential algorithms.
- *
- * @return array algorithms
- */
-function getCredentialParameters() {
-	return array(
-		new PublicKeyCredentialParameters('public-key', Algorithms::COSE_ALGORITHM_ES256),
-		new PublicKeyCredentialParameters('public-key', Algorithms::COSE_ALGORITHM_RS256),
-	);
-}
+	/**
+	 * Returns the part that identifies the server and application.
+	 *
+	 * @param bool $isSelfService is executed in self service
+	 * @return PublicKeyCredentialRpEntity relying party entry
+	 */
+	private function createRpEntry($isSelfService) {
+		$pathPrefix = $isSelfService ? '../' : '';
+		$icon = $pathPrefix . '../graphics/logo136.png';
+		if (!$isSelfService) {
+			$domain = $_SESSION['config']->getTwoFactorAuthenticationDomain();
+		}
+		return new PublicKeyCredentialRpEntity(
+			'LDAP Account Manager', //Name
+			$domain,
+			$icon
+		);
+	}

-/**
- * Returns a list of all credential ids that are already registered.
- *
- * @param PublicKeyCredentialUserEntity $user user data
- * @return PublicKeyCredentialDescriptor[] credential ids
- */
-function getExcludedKeys($user) {
-	$keys = array();
-	$repository = new PublicKeyCredentialSourceRepositorySQLite();
-	$credentialSources = $repository->findAllForUserEntity($user);
-	foreach ($credentialSources as $credentialSource) {
-		$keys[] = new PublicKeyCredentialDescriptor(PublicKeyCredentialDescriptor::CREDENTIAL_TYPE_PUBLIC_KEY, $credentialSource->getPublicKeyCredentialId());
+	/**
+	 * Returns the supported credential algorithms.
+	 *
+	 * @return array algorithms
+	 */
+	private function getCredentialParameters() {
+		return array(
+			new PublicKeyCredentialParameters('public-key', Algorithms::COSE_ALGORITHM_ES256),
+			new PublicKeyCredentialParameters('public-key', Algorithms::COSE_ALGORITHM_RS256),
+		);
+	}
+
+	/**
+	 * Returns a list of all credential ids that are already registered.
+	 *
+	 * @param PublicKeyCredentialUserEntity $user user data
+	 * @return PublicKeyCredentialDescriptor[] credential ids
+	 */
+	private function getExcludedKeys($user) {
+		$keys = array();
+		$repository = $this->getDatabase();
+		$credentialSources = $repository->findAllForUserEntity($user);
+		foreach ($credentialSources as $credentialSource) {
+			$keys[] = new PublicKeyCredentialDescriptor(PublicKeyCredentialDescriptor::CREDENTIAL_TYPE_PUBLIC_KEY, $credentialSource->getPublicKeyCredentialId());
+		}
+		return $keys;
+	}
+
+	/**
+	 * Returns the webauthn database.
+	 *
+	 * @return PublicKeyCredentialSourceRepositorySQLite database
+	 */
+	public function getDatabase() {
+		return new PublicKeyCredentialSourceRepositorySQLite();
 	}
-	return $keys;
+
 }

 /**
@ -275,19 +296,6 @@ function getExtensionOutputChecker() {
 	return new ExtensionOutputCheckerHandler();
 }

-/**
- * Returns if there are any tokens registered for the given DN.
- *
- * @param string $dn user DN
- * @return bool at least one token is registered
- */
-function hasTokensRegistered($dn) {
-	$repository = new PublicKeyCredentialSourceRepositorySQLite();
-	$userEntity = getUserEntity($dn);
-	$tokens = $repository->findAllForUserEntity($userEntity);
-	return !empty($tokens);
-}
-
 /**
 * Stores the public key credentials in the SQLite database.
 *
--- a/lam/templates/misc/ajax.php
+++ b/lam/templates/misc/ajax.php
@ -7,8 +7,7 @@ use \htmlResponsiveRow;
 use \htmlLink;
 use \htmlOutputText;
 use \htmlButton;
-use function LAM\LOGIN\WEBAUTHN\getRegistrationObject;
-use function LAM\LOGIN\WEBAUTHN\isRegistered;
+use LAM\LOGIN\WEBAUTHN\WebauthnManager;

 /*

@ -193,9 +192,10 @@ class Ajax {
 	private function manageWebauthn($isSelfService) {
 		include_once __DIR__ . '/../../lib/webauthn.inc';
 		$userDN = $_SESSION['ldap']->getUserName();
-		$isRegistered = isRegistered($userDN);
+		$webauthnManager = new WebauthnManager();
+		$isRegistered = $webauthnManager->isRegistered($userDN);
 		if (!$isRegistered) {
-			$registrationObject = getRegistrationObject($userDN, $isSelfService);
+			$registrationObject = $webauthnManager->getRegistrationObject($userDN, $isSelfService);
 			$_SESSION['webauthn_registration'] = json_encode($registrationObject);
 			echo json_encode(
 				array(