From e3901f434ede62b2fd23e7e5a1b4c481196b6e05 Mon Sep 17 00:00:00 2001
From: Roland Gruber <post@rolandgruber.de>
Date: Fri, 2 Sep 2016 11:05:19 +0200
Subject: [PATCH] use ldap_modify_batch if available

---
 lam/lib/modules/windowsUser.inc | 46 +++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/lam/lib/modules/windowsUser.inc b/lam/lib/modules/windowsUser.inc
index c39a8af3..9dbd9a6c 100644
--- a/lam/lib/modules/windowsUser.inc
+++ b/lam/lib/modules/windowsUser.inc
@@ -2580,6 +2580,52 @@ class windowsUser extends baseModule implements passwordService {
 	 * @param array $attributes LDAP attributes
 	 */
 	private function setSelfServicePassword(&$return, $attributes) {
+		if (!function_exists('ldap_modify_batch')) {
+			return $this->setSelfServicePasswordCMD($return, $attributes);
+		}
+		$newPasswordVal = self::pwdAttributeValue($_POST['windowsUser_unicodePwd']);
+		$oldPassword = lamDecrypt($_SESSION['selfService_clientPassword'], 'SelfService');
+		$oldPasswordVal = self::pwdAttributeValue($oldPassword);
+		$dn = $attributes['dn'];
+		$operation = array(
+			array(
+				'attrib' => 'unicodePwd',
+				'modtype' => LDAP_MODIFY_BATCH_REMOVE,
+				'values' => array($oldPasswordVal)
+			),
+			array(
+				'attrib' => 'unicodePwd',
+				'modtype' => LDAP_MODIFY_BATCH_ADD,
+				'values' => array($newPasswordVal)
+			)
+		);
+		$success = @ldap_modify_batch($_SESSION['ldapHandle'], $dn, $operation);
+		$returnCode = ldap_errno($_SESSION['ldapHandle']);
+		if ($returnCode != 0) {
+			$outputMessages = htmlspecialchars(getExtendedLDAPErrorMessage($_SESSION['ldapHandle']));
+			// Active Directory message translations
+			if ((strpos($outputMessages, 'DSID-03190F80') !== false) && (strpos($outputMessages, 'unicodePwd') !== false)) {
+				$outputMessages = _('Your password does not meet the password strength qualifications. Please retry with another one.') . '<br><br>' . $outputMessages;
+			}
+			logNewMessage(LOG_ERR, 'Changing user password failed: ' . $outputMessages);
+			$return['messages'][] = array('ERROR', _('Unable to change password.'), $outputMessages);
+			return;
+		}
+		else {
+			// update session password for next page load
+			$_SESSION['selfService_clientPasswordNew'] = $_POST['windowsUser_unicodePwd'];
+		}
+	}
+
+	/**
+	 * Sets the user password in self service.
+	 * Since the change requires the old password we need to run ldapmodify for this task.
+	 *
+	 * Enter description here ...
+	 * @param array $return return value for checkSelfServiceOptions() (used to add message if any)
+	 * @param array $attributes LDAP attributes
+	 */
+	private function setSelfServicePasswordCMD(&$return, $attributes) {
 		$newPasswordVal = self::pwdAttributeValue($_POST['windowsUser_unicodePwd']);
 		$oldPassword = lamDecrypt($_SESSION['selfService_clientPassword'], 'SelfService');
 		$oldPasswordVal = self::pwdAttributeValue($oldPassword);