From eb609f7faa4edf36770d0faf392d8efa1326813f Mon Sep 17 00:00:00 2001
From: deajan <ozy@netpower.fr>
Date: Mon, 1 Oct 2018 20:13:58 +0200
Subject: [PATCH] Some release details

---
 dev/CODING_CONVENTIONS.TXT | 22 +++++++++++++---------
 dev/tests/run_tests.sh     |  1 +
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/dev/CODING_CONVENTIONS.TXT b/dev/CODING_CONVENTIONS.TXT
index 012766d..4a9a162 100644
--- a/dev/CODING_CONVENTIONS.TXT
+++ b/dev/CODING_CONVENTIONS.TXT
@@ -197,15 +197,6 @@ Quoting happens outside the function call.
 
 echo "$(myStringFunction $myStringVar)"
 
-++++++ Finding code errors
-
-Use shellcheck.net now and then (ignore SC2086 in our case)
-
-Use a low tech approach to find uneven number of quotes per line
-
-tr -cd "'\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
-tr -cd "\"\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
-
 ++++++ ofunctions
 
 As obackup and osync share alot of common functions, ofunctions.sh will host all shared code.
@@ -258,3 +249,16 @@ When launching the program with 'bash -x', add SLEEP_TIME=1 so wait functions wo
 Ex:
 
 SLEEP_TIME=1 bash -x ./program.sh
+
+++++++ Finding code errors
+
+Before every release, shellcheck must be run
+Also a grep -Eri "TODO|WIP" osync/* must be run in order to find potential release blockers
+
+Use shellcheck.net now and then (ignore SC2086 in our case)
+
+Use a low tech approach to find uneven number of quotes per line
+
+tr -cd "'\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
+tr -cd "\"\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
+
diff --git a/dev/tests/run_tests.sh b/dev/tests/run_tests.sh
index 3d7ac42..af63afc 100755
--- a/dev/tests/run_tests.sh
+++ b/dev/tests/run_tests.sh
@@ -1395,6 +1395,7 @@ function test_DaemonMode () {
 		$OSYNC_EXECUTABLE "$CONF_DIR/$LOCAL_CONF" --on-changes &
 		pid=$!
 
+		#TODO: Lower that value when dispatecher is written
 		# Trivial value of 2xMIN_WAIT from config files
 		echo "Sleeping for 120s"
 		sleep 120