From e9a8caea514cfc23d76ee3ab502d01e43ca980c7 Mon Sep 17 00:00:00 2001
From: Tobias Herre <tobias.herre@wikimedia.de>
Date: Wed, 8 Nov 2023 12:22:28 +0000
Subject: [PATCH] Call connect with explicite paramters.

---
 lib/send.php | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/lib/send.php b/lib/send.php
index 852470a..1bffdaf 100644
--- a/lib/send.php
+++ b/lib/send.php
@@ -78,18 +78,21 @@ class password_recovery_send {
         $msg_body .= "--=_$ctb--";
         $msg_body .= "\r\n\r\n";
 
+	$smtp_host=null;
+	$smtp_user=null;
+	$smtp_pass=null;
+        if($this->rc->config->get('smtp_pass') == "%p") {
+            $smtp_server = $this->rc->config->get('pr_default_smtp_server');
+            $smtp_user = $this->rc->config->get('pr_default_smtp_user');
+            $smtp_pass = $this->rc->config->get('pr_default_smtp_pass');
+        }
+
         // send message
         if (!is_object($this->rc->smtp)) {
-            $this->rc->smtp_init(true);
+            $this->rc->smtp_init(false);
         }
 
-        if($this->rc->config->get('smtp_pass') == "%p") {
-            $this->rc->config->set('smtp_server', $this->rc->config->get('pr_default_smtp_server'));
-            $this->rc->config->set('smtp_user', $this->rc->config->get('pr_default_smtp_user'));
-            $this->rc->config->set('smtp_pass', $this->rc->config->get('pr_default_smtp_pass'));
-        }
-
-        $this->rc->smtp->connect();
+        $this->rc->smtp->connect($smtp_server,null, $smtp_user, $smtp_pass);
         if($this->rc->smtp->send_mail($from, $to, $headers, $msg_body)) {
             return true;
         } else {