WMDE
/
osync
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Some release details

This commit is contained in:
deajan 2018-10-01 20:13:58 +02:00
parent 7e678b6480
commit eb609f7faa
2 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dev/CODING_CONVENTIONS.TXT
View File

@ -197,15 +197,6 @@ Quoting happens outside the function call.
echo "$(myStringFunction $myStringVar)" echo "$(myStringFunction $myStringVar)"
++++++ Finding code errors
Use shellcheck.net now and then (ignore SC2086 in our case)
Use a low tech approach to find uneven number of quotes per line
tr -cd "'\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
tr -cd "\"\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
++++++ ofunctions ++++++ ofunctions
As obackup and osync share alot of common functions, ofunctions.sh will host all shared code. As obackup and osync share alot of common functions, ofunctions.sh will host all shared code.
@ -258,3 +249,16 @@ When launching the program with 'bash -x', add SLEEP_TIME=1 so wait functions wo
Ex: Ex:
SLEEP_TIME=1 bash -x ./program.sh SLEEP_TIME=1 bash -x ./program.sh
++++++ Finding code errors
Before every release, shellcheck must be run
Also a grep -Eri "TODO|WIP" osync/* must be run in order to find potential release blockers
Use shellcheck.net now and then (ignore SC2086 in our case)
Use a low tech approach to find uneven number of quotes per line
tr -cd "'\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'
tr -cd "\"\n" < my_bash_file.sh | awk 'length%2==1 {print NR, $0}'

1
dev/tests/run_tests.sh
View File

@ -1395,6 +1395,7 @@ function test_DaemonMode () {
$OSYNC_EXECUTABLE "$CONF_DIR/$LOCAL_CONF" --on-changes & $OSYNC_EXECUTABLE "$CONF_DIR/$LOCAL_CONF" --on-changes &
pid=$! pid=$!
#TODO: Lower that value when dispatecher is written
# Trivial value of 2xMIN_WAIT from config files # Trivial value of 2xMIN_WAIT from config files
echo "Sleeping for 120s" echo "Sleeping for 120s"
sleep 120 sleep 120